Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue: Add support for tsx #11936

Merged
merged 2 commits into from Jul 19, 2021
Merged

Vue: Add support for tsx #11936

merged 2 commits into from Jul 19, 2021

Conversation

@blake-newman
Copy link
Contributor

@blake-newman blake-newman commented Aug 12, 2020

Previous to this change vue file paths get ts suffix. However; if using <script lang="tsx"> we want tsx to be the suffix

Screenshot from 2020-08-12 13-31-30

What I did

This change adds tsx as a test rule and applies appendTsxSuffixTo.

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No
Previous to this change vue file paths get `ts` suffix. However; if using `<script lang="tsx">` we want `tsx` to be the suffix, this change adds `tsx` as a test rule and applies `appendTsxSuffixTo`
@stale
Copy link

@stale stale bot commented Sep 2, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Sep 2, 2020
@stale stale bot removed the inactive label Sep 3, 2020
@shilman shilman changed the title feat(app-vue): add support for tsx Vue: Add support for tsx Jul 19, 2021
@nx-cloud
Copy link

@nx-cloud nx-cloud bot commented Jul 19, 2021

Nx Cloud Report

CI ran the following commands for commit 618fc1c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Merging w/ help from @Aaron-Pool. Thanks for your patience!! 🙈

@shilman shilman merged commit 1932d62 into storybookjs:next Jul 19, 2021
34 of 38 checks passed
@blake-newman blake-newman deleted the patch-1 branch Jul 20, 2021
@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants