Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Add aurelia detection #12181

Merged
merged 2 commits into from Aug 31, 2020
Merged

CLI: Add aurelia detection #12181

merged 2 commits into from Aug 31, 2020

Conversation

tooppaaa
Copy link
Contributor

Issue:
Aurelia is not part of the detected framework
Preparatory work for e2e on this framework

What I did

Add detection

How to test

  • npx aurelia-cli@ new aurelia-latest --unattended
  • sb init (locally of course)

@tooppaaa tooppaaa requested a review from yannbf August 21, 2020 07:45
@tooppaaa tooppaaa added app: aurelia cli maintenance User-facing maintenance tasks labels Aug 21, 2020
@shilman shilman added this to the 6.1 maintenance milestone Aug 21, 2020
shilman
shilman approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's merge when we start 6.1

yannbf
yannbf reviewed Aug 24, 2020
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
I believe there are different ways of setting up Aurelia projects, and one of them includes using jspm (check here and here) and such format is not in our detection, BUT I have no experience with Aurelia, so let's ask the expert!

Hey @brandonseydel, what are the possible ways to detect if a project is an Aurelia project? Are the generated templates via storybook CLI compliant with older projects or only new ones? We need to figure out if a user has an Aurelia project and runs sb init if they will get a properly set Storybook for them, and even if we support all versions. Thanks!

@shilman shilman changed the title CLI: add aurelia detection CLI: Add aurelia detection Aug 31, 2020
@shilman shilman merged commit 1a1a5e2 into next Aug 31, 2020
@shilman shilman deleted the fix/aureliaDetection branch August 31, 2020 12:27
@brandonseydel
Copy link
Contributor

@tooppaaa this is aurelia 2 and such this will not work.

@tooppaaa
Copy link
Contributor Author

@brandonseydel you mean this dependencies: ['aurelia-bootstrapper'], ? I'm not sure what to put here, I'm happy to use your suggestions :)

@brandonseydel
Copy link
Contributor

'aurelia' || '@aurelia/runtime'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf left review comments

@shilman shilman shilman approved these changes

@ndelangen ndelangen ndelangen approved these changes

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

Assignees
No one assigned
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.1 maintenance
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tooppaaa @brandonseydel @shilman @yannbf @ndelangen