Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix link to sb init docs #14421

Merged
merged 1 commit into from Mar 31, 2021
Merged

CLI: Fix link to sb init docs #14421

merged 1 commit into from Mar 31, 2021

Conversation

jonniebigodes
Copy link
Contributor

@jonniebigodes jonniebigodes commented Mar 31, 2021

With this pull request the Storybook CLI is updated to provide the proper URL and message when the user attempts to install Storybook into an empty project. The URL currently provided is pointing to https://storybook.js.org/basics/slow-start-guide/, which is resolved into https://storybook.js.org/docs/react/configure/overview, which should not be the case.

I ran into this small issue while watching this.

@shilman I left the cli label attached to this pull request, let me know I need any additional ones.

Feel free to provide feedback

@github-actions
Copy link

github-actions bot commented Mar 31, 2021

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies","other"]

Generated by 🚫 dangerJS against 3796d21

Copy link
Member

@shilman shilman left a comment

Excellent @jonniebigodes thanks for this! 🙏

@shilman shilman changed the title Chore: (CLI) Fix the message and url when the user attempts to add Storybook to an empty project CLI: Fix link to sb init docs Mar 31, 2021
@shilman shilman merged commit 10e0671 into next Mar 31, 2021
32 of 40 checks passed
@shilman shilman deleted the fix_url_cli branch Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants