Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs/ArgsTable: Fix sort parameter propagation #14422

Merged
merged 1 commit into from Apr 2, 2021
Merged

Conversation

tooppaaa
Copy link
Contributor

@tooppaaa tooppaaa commented Mar 31, 2021

Issue: #14414

What I did

Pass down storySort

How to test

@tooppaaa
Copy link
Contributor Author

tooppaaa commented Mar 31, 2021

@shilman, I think this can be a quick fix but there's something weird here.
Docs is picking the storySort of the current story when I think this should be the one from .

However the cases where we have multiple sorts per story should be pretty rare right ?

@shilman shilman changed the title Docs: Use storySort parameter Addon-docs/ArgsTable: Use storySort parameter Apr 2, 2021
shilman
shilman approved these changes Apr 2, 2021
Copy link
Member

@shilman shilman left a comment

LGTM!

@shilman shilman merged commit d9dcd16 into next Apr 2, 2021
34 of 41 checks passed
@shilman shilman deleted the fix/storySortDocs branch Apr 2, 2021
@shilman shilman changed the title Addon-docs/ArgsTable: Use storySort parameter Addon-docs/ArgsTable: Fix sort parameter propagation Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants