Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix symlinks in static dir when building static Storybook #14448

Merged
merged 1 commit into from Apr 2, 2021

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Apr 2, 2021

Issue: -

What I did

  • Fixed symlink expansion in static dir when building Storybook
  • Keep original file timestamps when copying static dir

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

shilman
shilman approved these changes Apr 2, 2021
Copy link
Member

@shilman shilman left a comment

LGTM!

@shilman shilman changed the title Core: Handle symlinks in static dir when building static Storybook Core: Fix symlinks in static dir when building static Storybook Apr 2, 2021
@shilman shilman merged commit b499cf4 into next Apr 2, 2021
27 of 35 checks passed
@shilman shilman deleted the fix-build-static-symlinks branch Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants