Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte: Fix argType.type.name extraction #15332

Merged
merged 2 commits into from Jun 24, 2021
Merged

Svelte: Fix argType.type.name extraction #15332

merged 2 commits into from Jun 24, 2021

Conversation

@ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jun 23, 2021

Issue: #15278

What I did

ArgTypes for Svelte were incorrectly setting type.summary which should be type.name, as summary only exists in the context of table.

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

@nx-cloud nx-cloud bot commented Jun 23, 2021

Nx Cloud Report

CI ran the following commands for commit 0e158e7. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

LGTM! 🙏

@shilman shilman changed the title Fix argType.type.name for Svelte Svelte: Fix argType.type.name extraction Jun 23, 2021
@shilman shilman merged commit baf5ced into next Jun 24, 2021
39 of 41 checks passed
@shilman shilman deleted the svelte-argtype-name branch Jun 24, 2021
@shilman shilman added the patch label Jun 24, 2021
@shilman shilman added the picked label Jun 28, 2021
shilman added a commit that referenced this issue Jun 28, 2021
Svelte: Fix argType.type.name extraction
@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants