Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dotenv-webpack to 7.0.x #15343

Merged
merged 1 commit into from Jun 24, 2021
Merged

Upgrade dotenv-webpack to 7.0.x #15343

merged 1 commit into from Jun 24, 2021

Conversation

@shilman
Copy link
Member

@shilman shilman commented Jun 24, 2021

Issue: N/A

Related to #14257. Older versions of dotenv-webpack insert a dummy DefinePlugin when there is no .env file. This conflicts with Storybook's DefinePlugin, which causes a spurious warning in Webpack5:

WARNING in DefinePlugin
Conflicting values for 'process.env'

Self-merging @tmeasday

What I did

  • Upgrade to 7.0.x

How to test

I reproduced in this repo https://github.com/arty-name/storybook-webpack5-module/tree/module-not-found and was able to manually upgrade and fix the warning

@nx-cloud
Copy link

@nx-cloud nx-cloud bot commented Jun 24, 2021

Nx Cloud Report

CI ran the following commands for commit ce3c592. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman merged commit 7f74797 into next Jun 24, 2021
44 of 47 checks passed
@shilman shilman deleted the 15335-upgrade-dotenv-webpack branch Jun 24, 2021
@shilman shilman added the picked label Jun 28, 2021
shilman added a commit that referenced this issue Jun 28, 2021
@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant