Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix navigation after no story error #15349

Merged
merged 4 commits into from Jun 25, 2021
Merged

Conversation

@shilman
Copy link
Member

@shilman shilman commented Jun 24, 2021

Issue: #15310

What I did

  • Fix first story navigation after "no preview found" error

self-merging @ndelangen

How to test

  • Open an example storybook in the branch
  • Manually edit the URL to a non-existent storyId => "No preview" error should show
  • Navigate to a known story => Known story should show
@nx-cloud
Copy link

@nx-cloud nx-cloud bot commented Jun 24, 2021

Nx Cloud Report

CI ran the following commands for commit 2944969. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@yannbf
Copy link
Member

@yannbf yannbf commented Jun 24, 2021

@shilman Awesome stuff! Tested out and it works great.

The pipeline is failing for an unrelated issue:

UnhandledPromiseRejectionWarning: Error: @storybook/addons@npm:^6.3.0-beta.6: No candidates found

@shilman shilman merged commit d33d00a into next Jun 25, 2021
35 of 41 checks passed
@shilman shilman deleted the 15310-fix-first-navigation-on-error branch Jun 25, 2021
@shilman shilman added the picked label Jun 28, 2021
shilman added a commit that referenced this issue Jun 28, 2021
…-on-error

UI: Fix navigation after no story error
@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants