Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF3: Rename setup to play #15358

Merged
merged 1 commit into from Jun 25, 2021
Merged

CSF3: Rename setup to play #15358

merged 1 commit into from Jun 25, 2021

Conversation

@shilman
Copy link
Member

@shilman shilman commented Jun 25, 2021

Issue: N/A

What I did

Rename CSF3's setup function to play.

  • Setup implies something that happens before the render function.
  • Play implies a script that can be played/paused/re-played.

How to test

  • See AccountForm stories in examples/react-ts
  • See attached tests
@nx-cloud
Copy link

@nx-cloud nx-cloud bot commented Jun 25, 2021

Nx Cloud Report

CI ran the following commands for commit bd90a23. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

@nx-cloud nx-cloud bot commented Jun 25, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit bd90a23.
Please make sure you set the \ NX_BRANCH\ environment variable in your CI pipeline .

Check the Getting started section to configure the app.


Sent with 💌 from NxCloud.

@shilman shilman added the patch label Jun 25, 2021
Copy link
Member

@tmeasday tmeasday left a comment

Ok

@shilman shilman merged commit 0b81fe1 into next Jun 25, 2021
43 of 49 checks passed
@shilman shilman deleted the csf3-rename-setup-to-play branch Jun 25, 2021
@shilman shilman added the picked label Jun 28, 2021
shilman added a commit that referenced this issue Jun 28, 2021
@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants