Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF3: Fix webpack5 feature flagging & genericize flagging #15375

Merged
merged 1 commit into from Jun 26, 2021

Conversation

@shilman
Copy link
Member

@shilman shilman commented Jun 26, 2021

Issue: N/A

What I did

  • Fix webpack5 flagging for CSF3
  • Clean up feature flagging support

Self-merging @ndelangen

How to test

cd exapmles/react-ts
yarn storybook
@nx-cloud
Copy link

@nx-cloud nx-cloud bot commented Jun 26, 2021

Nx Cloud Report

CI ran the following commands for commit 39c7ba0. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman merged commit 8bca9ec into next Jun 26, 2021
44 of 49 checks passed
@shilman shilman deleted the fix/csf3-feature-flag-webpack5 branch Jun 26, 2021
@shilman shilman changed the title CSF3: Genericize feature flagging and fix webpack5 CSF3: Fix webpack5 feature flagging & genericize flagging Jun 26, 2021
@shilman shilman added the picked label Jun 28, 2021
shilman added a commit that referenced this issue Jun 28, 2021
…ack5

CSF3: Genericize feature flagging and fix webpack5
@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant