Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing comma handling for "-s" command line paramenter #15615

Merged
merged 1 commit into from Jul 18, 2021

Conversation

@apalumbo
Copy link
Contributor

@apalumbo apalumbo commented Jul 18, 2021

Issue: #15614

What I did

I changed the parsing of the "-s" value from command line to strip empty elements that will breaks chromatic upload

How to test

I added some unit tests to ensure the bugfix works

@nx-cloud
Copy link

@nx-cloud nx-cloud bot commented Jul 18, 2021

Nx Cloud Report

CI ran the following commands for commit c2f018d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@apalumbo
Copy link
Contributor Author

@apalumbo apalumbo commented Jul 18, 2021

IMHO the failing test are not related to the changes in the PR

Copy link
Member

@shilman shilman left a comment

Looking good! Nice tests! 💪

@shilman shilman added the patch label Jul 18, 2021
@shilman shilman merged commit e87b321 into storybookjs:next Jul 18, 2021
40 of 43 checks passed
@shilman shilman added the picked label Jul 22, 2021
shilman added a commit that referenced this issue Jul 22, 2021
Trailing comma handling for "-s" command line paramenter
@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants