Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Fix react-ts to be runnable standalone #15621

Merged
merged 2 commits into from Jul 19, 2021

Conversation

@graup
Copy link
Contributor

@graup graup commented Jul 19, 2021

Issue: the react-ts example is not runnable standalone

What I did

  • Added babelrc (this fixes the issue)
  • Cleaned up main.ts (removed addons already included in essentials)
  • Reordered package.json dependencies

How to test

Building the example is part of the E2E tests

@nx-cloud
Copy link

@nx-cloud nx-cloud bot commented Jul 19, 2021

Nx Cloud Report

CI ran the following commands for commit 0b74220. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

LGTM!

@shilman shilman changed the title Fix react-ts example to be runnable standalone Examples: Fix react-ts to be runnable standalone Jul 19, 2021
@shilman shilman merged commit 67ab465 into storybookjs:next Jul 19, 2021
36 of 40 checks passed
@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants