Skip to content

refactor: feat SnapshotsWithOptionsArgType#15712

Merged
ndelangen merged 2 commits intostorybookjs:nextfrom
mrskiro:feat-storyshots-argType
Jun 30, 2022
Merged

refactor: feat SnapshotsWithOptionsArgType#15712
ndelangen merged 2 commits intostorybookjs:nextfrom
mrskiro:feat-storyshots-argType

Conversation

@mrskiro
Copy link
Contributor

@mrskiro mrskiro commented Jul 29, 2021

What I did

When using multiSnapshotWithOptions, I consumed a lot of time wondering what to pass as an argument. So I added a type for the arguments.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jul 29, 2021

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 710ca9c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@darleendenno
Copy link
Contributor

hi @purp1eeeee ! thanks for doing this!! I plan to pull this down soon and test it out, but on a code level all looks good!

@mrskiro
Copy link
Contributor Author

mrskiro commented Sep 17, 2021

@darleendenno @shilman
hi. Thank you for taking the time to look over this PR.
Do you know when this will be merged?

@darleendenno darleendenno removed their assignment Sep 23, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jan 9, 2022
@stale stale bot removed the inactive label Jun 30, 2022
@ndelangen ndelangen merged commit a14a943 into storybookjs:next Jun 30, 2022
@mrskiro mrskiro deleted the feat-storyshots-argType branch July 1, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants