Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Theming) Replace references to themes.normal with themes.light #17034

Conversation

richorrichard
Copy link
Contributor

@richorrichard richorrichard commented Dec 17, 2021

Issue: #16937

What I did

Replaced all non-breaking references to themes.normal with themes.light. Changes made to addons and examples. There were no tests for this functionality and, given the small scale of the updates, I didn't see a need to add a new test. I did, however, manually verify that using themes.normal still works as a base theme and as a theme selection in .storybook/manager.js.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Dec 17, 2021

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dad261a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added documentation patch Bugfix & documentation PR that need to be picked to master branch labels Dec 18, 2021
@MichaelArestad MichaelArestad self-assigned this Dec 20, 2021
@richorrichard
Copy link
Contributor Author

richorrichard commented Jan 10, 2022

HI all - please let me know if there is anything else that needs to be updated for this PR. Now that the holidays are past I've got more time to attend to any additional items that need an update here. Thanks!

@jonniebigodes
Copy link
Contributor

jonniebigodes commented May 27, 2022

@MichaelArestad putting this on your radar so that we don't lose track of it. If changes are required to the docs I'm more than glad to make them.

@MichaelArestad MichaelArestad self-requested a review Jun 22, 2022
@ndelangen ndelangen merged commit c2b1b9c into storybookjs:next Jul 1, 2022
42 of 44 checks passed
@shilman shilman added the picked Patch/release PRs cherry-picked to master/release branch label Jul 26, 2022
shilman pushed a commit that referenced this issue Jul 26, 2022
…mal-theme-to-light-theme

(Theming) Replace references to `themes.normal` with `themes.light`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants