Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CSS pseudo selector #17708

Merged
merged 3 commits into from Jun 28, 2022
Merged

Conversation

rygine
Copy link
Contributor

@rygine rygine commented Mar 14, 2022

Issue:

What I did

Replaced laste-of-type with last-of-type in a CSS selector.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Mar 14, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 36708b3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Thanks so much @rygine !! Fix looks good to me 🙈

@shilman shilman added bug ui patch Bugfix & documentation PR that need to be picked to master branch block: argstable labels Mar 15, 2022
@ndelangen ndelangen assigned ndelangen and unassigned MichaelArestad May 2, 2022
@IanVS
Copy link
Member

IanVS commented Jun 6, 2022

Hi, is there a reason not to merge this PR?

@MichaelArestad
Copy link
Contributor

MichaelArestad commented Jun 22, 2022

@shilman This is good to go. Can you merge when you get a chance?

@ndelangen ndelangen merged commit 008b542 into storybookjs:next Jun 28, 2022
33 of 37 checks passed
@IanVS
Copy link
Member

IanVS commented Jun 28, 2022

Maybe this can be picked into 6.5?

@ndelangen
Copy link
Member

ndelangen commented Jun 29, 2022

Yeah It's labelled patch so @shilman should be picking it soon-ish.

@IanVS
Copy link
Member

IanVS commented Jun 29, 2022

Oh cool, I missed that, thanks!

@shilman shilman added the picked Patch/release PRs cherry-picked to master/release branch label Jul 26, 2022
shilman pushed a commit that referenced this issue Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: argstable bug patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants