Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix automigration scripts #18302

Merged
merged 2 commits into from May 23, 2022
Merged

CLI: Fix automigration scripts #18302

merged 2 commits into from May 23, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 23, 2022

Issue:

CI is currently broken because tests hang (automigration is prompting on Vue3 and should not)

What I did

A few improvements to the CLI and automigration tool:

1 - When installing Storybook, wait for dependency installation to stop before running automigration
2 - Fix the --yes flag in automigration and set it to true in CI

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented May 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9afa130. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf force-pushed the fix/automigration-scripts branch from a1938d2 to 9afa130 Compare May 23, 2022
Copy link
Member

@shilman shilman left a comment

LGTM 🙏

@shilman shilman added the patch Bugfix & documentation PR that need to be picked to master branch label May 23, 2022
@shilman shilman changed the title CLI: fix automigration scripts CLI: Fix automigration scripts May 23, 2022
@yannbf yannbf merged commit 9fbf0e2 into next May 23, 2022
48 of 50 checks passed
@yannbf yannbf deleted the fix/automigration-scripts branch May 23, 2022
@shilman shilman added the picked Patch/release PRs cherry-picked to master/release branch label May 23, 2022
shilman pushed a commit that referenced this issue May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants