Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix open in browser doesn't work in WSL #18305

Merged
merged 1 commit into from May 24, 2022

Conversation

lesha1201
Copy link
Contributor

@lesha1201 lesha1201 commented May 23, 2022

Issue: #18304

On Linux, x-default-browser requires xdg-utils to be installed to determine a default browser. So it fails when it's not installed. However, in WSL, we still can open a browser without it. Now it fallbacks to open when x-default-browser fails which makes it work on WSL without xdg-utils.

Tags: ["bug"]

On Linux, `x-default-browser` requires `xdg-utils` to be installed to
determine a default browser. So it fails when it's not installed.
However, in WSL, we still can open a browser without it. Now it
fallbacks to `open` when `x-default-browser` fails which makes it work on WSL
without `xdg-utils`.
@nx-cloud
Copy link

nx-cloud bot commented May 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit eab88cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added bug cli patch Bugfix & documentation PR that need to be picked to master branch labels May 24, 2022
Copy link
Member

@shilman shilman left a comment

Change LGTM!

@shilman shilman changed the title Fix open in browser doesn't work in WSL CLI: Fix open in browser doesn't work in WSL May 24, 2022
@shilman shilman merged commit 4b849f9 into storybookjs:next May 24, 2022
46 of 49 checks passed
@shilman shilman added the picked Patch/release PRs cherry-picked to master/release branch label May 24, 2022
shilman added a commit that referenced this issue May 24, 2022
CLI: Fix open in browser doesn't work in WSL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants