Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF: Fix auto-title crash on file ID and show warning #18307

Merged
merged 1 commit into from May 24, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented May 24, 2022

Issue: #18281

What I did

  • Fix broken autoTitle case and show warning

Self-merging @yannbf

How to test

  • CI passes

@nx-cloud
Copy link

nx-cloud bot commented May 24, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit df72f45. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added bug core csf3 patch Bugfix & documentation PR that need to be picked to master branch labels May 24, 2022
@shilman shilman added this to the 6.5 stabilization milestone May 24, 2022
@shilman shilman merged commit 9cb5699 into next May 24, 2022
60 of 62 checks passed
@shilman shilman deleted the 18281-fix-auto-title-file-id branch May 24, 2022
@yannbf
Copy link
Member

yannbf commented May 24, 2022

awesome work @shilman

@shilman shilman added the picked Patch/release PRs cherry-picked to master/release branch label May 24, 2022
shilman added a commit that referenced this issue May 24, 2022
CSF: Fix auto-title crash on file ID and show warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core csf3 patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants