Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add support for angular/cli@14.0.0 #18334

Conversation

stefanoslig
Copy link

@stefanoslig stefanoslig commented May 26, 2022

Issue: #18316

What I did

I have explained already in the issue what is the problem.

When the angular.json file doesn't contain the defaultProject property (which is the case when you create a project with angular/cli@14.0.0), then the default project is the first available project.

The solution is backwards compatible with the previous versions of the angular-cli

How to test

  1. npm install -g @angular/cli@next
  2. under the storybook/examples folder run ng new sb-ng14
  3. run npx sb init

Maybe there is a better way to test it

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented May 26, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e5841e4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@yannbf yannbf left a comment

Good stuff @stefanoslig, thanks for your contribution!
I added a couple comments

@yannbf yannbf self-assigned this May 30, 2022
@stefanoslig stefanoslig force-pushed the feat/angular-cli-default-project-deprecation branch from 8601ed1 to e5841e4 Compare May 31, 2022
yannbf
yannbf approved these changes Jun 2, 2022
Copy link
Member

@yannbf yannbf left a comment

LGTM! Thanks a lot @stefanoslig !!

@yannbf yannbf added linear patch Bugfix & documentation PR that need to be picked to master branch labels Jun 3, 2022
@yannbf yannbf merged commit 95bd68d into storybookjs:next Jun 3, 2022
42 of 45 checks passed
@shilman shilman added the picked Patch/release PRs cherry-picked to master/release branch label Jun 3, 2022
shilman pushed a commit that referenced this issue Jun 3, 2022
…roject-deprecation

feat(cli): Add support for angular/cli@14.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: angular bug linear patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants