Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Re-bundle the syntax highlighter #18425

Merged
merged 2 commits into from Jun 14, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 7, 2022

Issue: we removed the highlighter from the prebundled code, now we can add it back

@ndelangen ndelangen requested a review from shilman Jun 7, 2022
@ndelangen ndelangen self-assigned this Jun 7, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jun 7, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6ea5609. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title re-bundle the syntax highlighter again inside lib/components Components: Re-bundle the syntax highlighter Jun 8, 2022
shilman
shilman approved these changes Jun 8, 2022
Copy link
Member

@shilman shilman left a comment

LGTM. Thanks @ndelangen !

@shilman shilman added the patch Bugfix & documentation PR that need to be picked to master branch label Jun 8, 2022
@ndelangen ndelangen merged commit 33bf40e into next Jun 14, 2022
39 of 46 checks passed
@ndelangen ndelangen deleted the tech/rebundle-syntax-highlighter branch Jun 14, 2022
@iamandrewluca
Copy link
Contributor

iamandrewluca commented Jun 29, 2022

Related PR #18169

shilman pushed a commit that referenced this issue Jul 26, 2022
…ighter

Components: Re-bundle the syntax highlighter
@shilman shilman added the picked Patch/release PRs cherry-picked to master/release branch label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components maintenance patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants