Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update manager to respect parameters.docsOnly in stories.json #18433

Merged
merged 1 commit into from Jun 8, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jun 8, 2022

We sometimes set this in 6.x (if using storyStoreV7 = false and breakingChangesV7 = false), but we plan to use this for back-compat purposes in 7.x.

How to test

See tests

We sometimes set this in 6.x (if using `storyStoreV7 = false` and `breakingChangesV7 = false`), but we plan to use this for back-compat purposes in 7.x.
@nx-cloud
Copy link

nx-cloud bot commented Jun 8, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c8f611c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 1 target

Sent with 💌 from NxCloud.

@tmeasday tmeasday added patch Bugfix & documentation PR that need to be picked to master branch feature request labels Jun 8, 2022
@tmeasday
Copy link
Member Author

tmeasday commented Jun 8, 2022

We'd like to double-patch this back to 6.4.x

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #18433 (c8f611c) into next (7a48cd5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             next   #18433   +/-   ##
=======================================
  Coverage   32.01%   32.01%           
=======================================
  Files         975      975           
  Lines       19234    19234           
  Branches     4033     4033           
=======================================
  Hits         6158     6158           
  Misses      12513    12513           
  Partials      563      563           
Impacted Files Coverage Δ
lib/api/src/lib/stories.ts 87.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a48cd5...c8f611c. Read the comment docs.

@shilman shilman changed the title Update manager to look at parameters.docsOnly in stories.json. UI: Update manager to respect parameters.docsOnly in stories.json Jun 8, 2022
shilman
shilman approved these changes Jun 8, 2022
Copy link
Member

@shilman shilman left a comment

LGTM 👍

id,
kind: title,
name,
parameters: { fileName: importPath, options: {}, docsOnly, ...parameters },
Copy link
Member

@shilman shilman Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmeasday could ...parameters ever override options or fileName? if so, would that be an issue?

Copy link
Member Author

@tmeasday tmeasday Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fileName will always be the same. I think we just define options here because other code assumes it exists, I don't really remember why.

@shilman shilman merged commit 08351b7 into next Jun 8, 2022
51 of 56 checks passed
@shilman shilman deleted the tom/sb-412-include-legacy-fields-in-storiesjson-and branch Jun 8, 2022
@shilman shilman added story index picked Patch/release PRs cherry-picked to master/release branch labels Jun 8, 2022
shilman added a commit that referenced this issue Jun 9, 2022
…fields-in-storiesjson-and

UI: Update manager to respect `parameters.docsOnly` in `stories.json`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch story index
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants