Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix process is not defined when using components #18469

Merged
merged 1 commit into from Jun 13, 2022

Conversation

joshwooding
Copy link
Contributor

@joshwooding joshwooding commented Jun 13, 2022

Issue: #18366

What I did

In the last PR (#18367) I forgot to move memoizerific in @storybook/components.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jun 13, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b560bbc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added bug patch Bugfix & documentation PR that need to be picked to master branch core labels Jun 13, 2022
Copy link
Member

@shilman shilman left a comment

LGTM! Thanks @joshwooding

@shilman shilman merged commit bd50116 into storybookjs:next Jun 13, 2022
40 of 49 checks passed
@joshwooding joshwooding deleted the move-memoizerific-to-deps branch Jun 13, 2022
@shilman shilman added the picked Patch/release PRs cherry-picked to master/release branch label Jun 13, 2022
shilman added a commit that referenced this issue Jun 13, 2022
Core: Fix process is not defined when using components
IanVS added a commit to storybookjs/builder-vite that referenced this issue Jun 21, 2022
IanVS added a commit to storybookjs/builder-vite that referenced this issue Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants