Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix display skip to sidebar button #18479

Merged
merged 1 commit into from Jun 15, 2022
Merged

Conversation

darleendenno
Copy link
Contributor

@darleendenno darleendenno commented Jun 14, 2022

Issue:

Skip to Sidebar button was not visible or executable after striking ENTER on the "Skip to Canvas" button and then striking TAB.

What I did

Made the "Skip to Sidebar" button visible and focusable by reverting a previous change. For context, click here to see where the breaking change occurred.

Screenshots

Before:

before.mov

After:

after.mov

How to test

Run a build and view the core storybook. Hit TAB until "Skip to Canvas" is selected, strike ENTER, strike TAB -- Skip to Sidebar button should be selected.

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jun 14, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3858015. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen
Copy link
Member

ndelangen commented Jun 15, 2022

Thank you @darleendenno 👏

@ndelangen ndelangen merged commit 15ce29a into next Jun 15, 2022
50 of 58 checks passed
@ndelangen ndelangen deleted the fix/skip-to-sidebar-button branch Jun 15, 2022
@shilman shilman changed the title fix: display skip to sidebar button UI: Fix display skip to sidebar button Jun 16, 2022
@shilman shilman added the patch Bugfix & documentation PR that need to be picked to master branch label Jun 16, 2022
@shilman shilman added the picked Patch/release PRs cherry-picked to master/release branch label Jul 26, 2022
shilman pushed a commit that referenced this issue Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants