Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add npm7 migration for legacy peer deps #18510

Merged
merged 2 commits into from Jun 20, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jun 19, 2022

Issue: #18298

What I did

Created an npm7 migration

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@tmeasday tmeasday added core yarn / npm Yarn / npm acting weird labels Jun 19, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jun 19, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 10afa9e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title Created npm7 migration for legacy peer deps CLI: Add npm7 migration for legacy peer deps Jun 19, 2022
@tmeasday tmeasday marked this pull request as ready for review Jun 20, 2022
@tmeasday tmeasday added bug patch Bugfix & documentation PR that need to be picked to master branch labels Jun 20, 2022
Copy link
Member

@shilman shilman left a comment

LGTM. @yannbf mind testing this once I release the alpha?

@shilman shilman merged commit e5c2bb6 into next Jun 20, 2022
48 of 55 checks passed
@shilman shilman deleted the tom/sb-372-sb18298-set-legacy-peer-deps=true-in branch Jun 20, 2022
@shilman shilman added the picked Patch/release PRs cherry-picked to master/release branch label Jul 26, 2022
shilman added a commit that referenced this issue Jul 26, 2022
…acy-peer-deps=true-in

CLI: Add npm7 migration for legacy peer deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch yarn / npm Yarn / npm acting weird
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants