Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLI): throw error on failure in sb init #18816

Merged
merged 1 commit into from Jul 31, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 29, 2022

Issue: N/A

What I did

When running sb init, if there is an issue, it was being swallowed as Uncaught exception and exiting with code 0.

This PR fixes that behavior

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added bug cli patch Bugfix & documentation PR that need to be picked to master branch labels Jul 29, 2022
Copy link
Member

@tmeasday tmeasday left a comment

OK!

@tmeasday tmeasday merged commit 0180f5b into next Jul 31, 2022
53 of 58 checks passed
@tmeasday tmeasday deleted the fix/sb-init-uncaught-exception branch Jul 31, 2022
@shilman shilman added the picked Patch/release PRs cherry-picked to master/release branch label Aug 2, 2022
shilman pushed a commit that referenced this issue Aug 2, 2022
…tion

fix(CLI): throw error on failure in sb init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch Bugfix & documentation PR that need to be picked to master branch picked Patch/release PRs cherry-picked to master/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants