Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI/React native: Fix addons template to import register instead of manager #19620

Merged
merged 1 commit into from Oct 26, 2022

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Oct 25, 2022

React native's stable version uses 5.3 where register is still the correct import

Issue:

What I did

Updated the react native template for 5.3 to use register instead of manager since in that version its the correct import.

How to test

generate a new react naitve project and the server should work with the included addons

React native's stable version uses 5.3 where register is still the correct import
@dannyhw dannyhw self-assigned this Oct 25, 2022
@dannyhw dannyhw added the bug label Oct 25, 2022
@dannyhw dannyhw requested a review from shilman October 25, 2022 16:32
@shilman shilman changed the title fix: on react native for addon imports register should be used instead of manager CLI/React native: Fix addons template to import register instead of manager Oct 26, 2022
@shilman shilman added react-native cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 26, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dannyhw

@shilman shilman merged commit a578aa7 into next Oct 26, 2022
117 of 125 checks passed
@shilman shilman deleted the react-native-cli-template-register branch October 26, 2022 02:03
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 19, 2022
shilman added a commit that referenced this pull request Nov 19, 2022
…register

CLI/React native: Fix addons template to import register instead of manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants