Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6975: @storybook/ui TS incremental migration - Part 1 #6976

Open
wants to merge 2 commits into
base: next
from

Conversation

Projects
None yet
3 participants
@leoyli
Copy link
Contributor

commented Jun 5, 2019

What I did

  • Turned off noImplicitAny flag to make sure the package can be built.
  • Break big monolith code into modular functions/files.
  • Progressively add type declarations.

How to test

  • Is this testable with Jest or Chromatic screenshots?
    Use the existed tests. Should have nothing effected.

  • Does this need a new example in the kitchen sink apps?
    No.

  • Does this need an update to the documentation?
    No.


As discussed with @ndelangen, it would be more pragmatic to migrate small chunks of code into TS, meaning it will take several incremental steps. Please also have a look in #6975.

Please note, many typing information is still missed. It is more just a housekeeping task. My goal is to get PR as small as possible so my work won't be drained or blocking any one. It would also important to get calibrated from early feedbacks. :)

@leoyli leoyli added this to the 5.2.0 milestone Jun 5, 2019

@leoyli leoyli requested review from igor-dv, ndelangen and tmeasday as code owners Jun 5, 2019

@leoyli leoyli self-assigned this Jun 5, 2019

@now

This comment has been minimized.

Copy link

commented Jun 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-6795-ui-ts-migration-part-1.storybook.now.sh

@leoyli leoyli force-pushed the 6795-UI-TS-migration-part-1 branch from e6ddce9 to dd7009e Jun 5, 2019

@now now bot requested a deployment to staging Jun 5, 2019 Pending

@leoyli leoyli changed the title 6975: Break big chunks of code into smaller modular functions 6975: @stoybook/ui incremental migration - Part 1 Jun 5, 2019

@leoyli leoyli changed the title 6975: @stoybook/ui incremental migration - Part 1 6975: @storybook/ui TS incremental migration - Part 1 Jun 5, 2019

@vutran
Copy link

left a comment

So glad to see this kicking off!

@ndelangen ndelangen self-assigned this Jun 17, 2019

@now now bot had a problem deploying to staging Jun 17, 2019 Failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.