Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log loading angular cli config error #7484

Merged
merged 4 commits into from Jul 24, 2019

Conversation

@JounQin
Copy link
Contributor

JounQin commented Jul 19, 2019

It would be mush more helpful for users to check why the config is not loaded successfully

Issue:

What I did

Just add log info for loading angular cli config error

How to test

  • Is this testable with Jest or Chromatic screenshots?
    Not needed

  • Does this need a new example in the kitchen sink apps?
    Not needed

  • Does this need an update to the documentation?
    Not needed

If your answer is yes to any of these, please make sure to include it in your PR.

@JounQin JounQin requested review from alterx and igor-dv as code owners Jul 19, 2019
@now

This comment has been minimized.

Copy link

now bot commented Jul 19, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-jounqin-chore-tracengclierror.storybook.now.sh

@now now bot temporarily deployed to staging Jul 19, 2019 Inactive
JounQin added 2 commits Jul 19, 2019
It would be mush more helpful for users to check why the config is not loaded successfully
@JounQin JounQin force-pushed the JounQin:chore/trace_ng_cli_error branch from ac0df85 to 9017b7c Jul 19, 2019
@kroeder kroeder self-assigned this Jul 23, 2019
@now now bot temporarily deployed to staging Jul 24, 2019 Inactive
Copy link
Member

kroeder left a comment

LGTM

@kroeder kroeder added the maintenance label Jul 24, 2019
@shilman shilman merged commit a089555 into storybookjs:next Jul 24, 2019
23 of 24 checks passed
23 of 24 checks passed
DeepScan 10 new and 10 fixed issues
Details
Pages changed 149 new files uploaded
Details
packtracker/images No images assets found.
Details
packtracker/javascript 6.12 MB — No Change
Details
Danger All green. Congrats.
Details
Header rules 1 header rule processed
Details
Mixed content No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
build_test_deploy Workflow: build_test_deploy
Details
ci/chromatic 7 changes accepted.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: chromatic Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: examples Your tests passed on CircleCI!
Details
ci/circleci: frontpage Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: native-smoke-tests Your tests passed on CircleCI!
Details
ci/circleci: packtracker Your tests passed on CircleCI!
Details
ci/circleci: smoke-tests Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
now Deployment has completed
Details
@JounQin JounQin deleted the JounQin:chore/trace_ng_cli_error branch Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.