Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Use telejson for websockets channel #9867

Merged
merged 2 commits into from Feb 16, 2020
Merged

Core: Use telejson for websockets channel #9867

merged 2 commits into from Feb 16, 2020

Conversation

@Gongreg
Copy link
Member

@Gongreg Gongreg commented Feb 15, 2020

Issue: storybookjs/react-native#13

What I did

As @Hypnosphi recommended, using telejson for serialization.

How to test

No tests for react-native-server available yet. Tested it manually.

@ndelangen @shilman, I think react-native is the only user of this package. Maybe it should be moved to rn monorepo?

@ndelangen
Copy link
Member

@ndelangen ndelangen commented Feb 15, 2020

Moving it sounds good to me!

@shilman shilman changed the title using telejson for websockets Core: Use telejson for websockets channel Feb 16, 2020
Copy link
Member

@shilman shilman left a comment

LGTM - agree moving it would be 💯

@shilman shilman merged commit ab9c9cb into next Feb 16, 2020
27 of 30 checks passed
27 of 30 checks passed
@github-actions
Puppeteer & A11y tests Puppeteer & A11y tests
Details
@github-actions
Automention
Details
@github-actions
CLI Fixtures
Details
@github-actions
Danger JS
Details
@github-actions
Latest CRA
Details
@packtracker
packtracker/images Awaiting your base commit report...
Details
@packtracker
packtracker/javascript Awaiting your base commit report...
Details
@netlify
Header rules No header rules processed
Details
@netlify
Pages changed All files already uploaded
Details
@netlify
Redirect rules No redirect rules processed
Details
@github-actions
Danger All green. Well done.
Details
DeepScan 0 new and 0 fixed issues
Details
Docs (Storybook) TeamCity build finished
Details
@netlify
Mixed content No mixed content detected
Details
ci/chromatic 379 stories unchanged.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: chromatic Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: e2e Your tests passed on CircleCI!
Details
ci/circleci: examples Your tests passed on CircleCI!
Details
ci/circleci: frontpage Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: packtracker Your tests passed on CircleCI!
Details
ci/circleci: smoke-tests Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@circleci-checks
deploy Workflow: deploy
Details
@netlify
deploy/netlify Deploy preview ready!
Details
@circleci-checks
test Workflow: test
Details
@shilman shilman deleted the websocket-cyclic-support branch Feb 16, 2020
@shilman shilman added the patch label Feb 16, 2020
@shilman shilman added the picked label Feb 25, 2020
shilman added a commit that referenced this pull request Feb 25, 2020
Core: Use telejson for websockets channel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants