-
Notifications
You must be signed in to change notification settings - Fork 41
Closed
Labels
Description
Describe the bug
When using yarn 2 (which has very strict module resolution), builds will error because this package references @storybook/core. This is both not installed by the default scaffold ^6.0.0 nor is it listed as a peer dependency of this package.
Steps to reproduce the behavior
- Scaffold new vue app
vue create .and follow prompts - Add this plugin
vue add storybookand use^6.0.0as the version - Bump yarn version
yarn set version berry yarn installyarn build- Observe error.
Expected behavior
I expect a default vue project, adding this plugin's generated code, and a build to succeed without failure.
Screenshots and/or logs
Error: vue-cli-plugin-storybook tried to access @storybook/core, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
Environment
- OS: OSX 10.15.7
- Node.js version: v14.12.0
- NPM version: yarn 2.2.2
- Browser (if applicable): n/a
- Browser version (if applicable): n/a
- Device (if applicable): n/a
Additional context
This is also incompatible with vue3, but will make a separate issue