Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Vue) Custom Parameters are not working #5874

Closed
PhillippOhlandt opened this Issue Mar 5, 2019 · 2 comments

Comments

2 participants
@PhillippOhlandt
Copy link

PhillippOhlandt commented Mar 5, 2019

Describe the bug
Hello,

I have a few stories where I don't need the panel because they act as content pages.

To Reproduce
Here is one typescript module:

import { storiesOf } from '@storybook/vue';

storiesOf('Specification', module)
  .addParameters({ options: { showPanel: false } })
  .add('Downloads', () => ({
    template: `
      <div style="padding: 20px; color: black; background: white;">
        <h1>Foo</h1>
      </div>
    `,
  }), { options: { showPanel: false } });

Expected behavior
When I browse to the story, the panel on the bottom should not be visible.

Current behavior
The panel stays visible. I also tried other options, e.g. setting the panel position to the right side, which also doesn't work.

System:

  • OS: macOS
  • Device: Macbook Pro 2015
  • Browser: Chrome
  • Framework: vue
  • Version: "@storybook/vue": "4.2.0-alpha.6",
@shilman

This comment has been minimized.

Copy link
Member

shilman commented Mar 5, 2019

Hi @PhillippOhlandt try this with the newly released @storybook/vue@5.0.0. I think you're looking at a new version of the docs but using those options with an old version of Storybook.

@PhillippOhlandt

This comment has been minimized.

Copy link
Author

PhillippOhlandt commented Mar 6, 2019

@shilman That could be it. Just saw that we have an open PR which updates to storybook v5 so I guess it will work as soon as it's merged. Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.