Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction for npm install with -D for development dependency #1168

Merged
merged 1 commit into from May 31, 2017
Merged

Add instruction for npm install with -D for development dependency #1168

merged 1 commit into from May 31, 2017

Conversation

yangli-io
Copy link
Contributor

Issue:

What I did

Update docs to add -D for development dependency

How to test

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks @yangli1990 !! 🏅

@shilman shilman merged commit 5f6cecd into storybookjs:master May 31, 2017
@codecov
Copy link

codecov bot commented May 31, 2017

Codecov Report

Merging #1168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1168   +/-   ##
=======================================
  Coverage   13.31%   13.31%           
=======================================
  Files         199      199           
  Lines        4589     4589           
  Branches      725      725           
=======================================
  Hits          611      611           
  Misses       3349     3349           
  Partials      629      629

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fceded0...c5bc6d2. Read the comment docs.

@ndelangen ndelangen changed the title Update README.md Add instruction for npm install with -D for development dependency Jun 2, 2017
@ndelangen ndelangen added this to the v3.0.1 milestone Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants