Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app entrypoint bug in RN gestorybook #1280

Merged
merged 3 commits into from Jun 15, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 14, 2017

Issue: #1277

What I did

  • replace APP_NAME in the correct file
  • add a warning if APP_NAME cannot be found

How to test

Run getstorybook in a fresh RN app and check the results

- replace APP_NAME in the correct file
- add a warning if APP_NAME cannot be found
@storybookbot
Copy link
Collaborator

Fails
🚫

PR is not labeled with one of: ["cleanup","breaking","feature","bug","documentation","maintenance","greenkeeper","other"]

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Jun 14, 2017

Codecov Report

Merging #1280 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
+ Coverage   13.71%   13.73%   +0.02%     
==========================================
  Files         207      207              
  Lines        4646     4638       -8     
  Branches      526      638     +112     
==========================================
  Hits          637      637              
+ Misses       3542     3443      -99     
- Partials      467      558      +91
Impacted Files Coverage Δ
addons/storyshots/src/test-bodies.js 0% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
...src/server/config/WatchMissingNodeModulesPlugin.js 0% <0%> (ø) ⬆️
addons/info/src/components/Node.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 38.57% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 0% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103c72e...ea6224a. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Great job

@shilman shilman merged commit 5e1cbb3 into master Jun 15, 2017
@shilman shilman deleted the 1277-react-native-getstorybook branch June 15, 2017 02:20
@shilman shilman changed the title Fix bug in RN gestorybook Fix app entry point bug in RN gestorybook Jun 15, 2017
@shilman shilman changed the title Fix app entry point bug in RN gestorybook Fix app entrypoint bug in RN gestorybook Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants