Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Add web-components/lit framework support #19164

Merged
merged 30 commits into from Oct 10, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 11, 2022

Issue: N/A

What I did

  • web-components/vite framework
  • JS/TS repro-templates
  • web-components improvements
    • default render function 🎉
    • template components
    • template stories
  • delete web-components-kitchen-sink

How to test

  • CI passes

@shilman
Copy link
Member Author

shilman commented Sep 11, 2022

@ndelangen the repro generation is failing because it uses yarn bootstrap --prep and that fails on the angular examples with errors like this:

> nx run @storybook/angular:prep --reset

ERR! FAILED (ts) : ../../lib/api/src/modules/versions.ts:2:1 - error TS2578: Unused '@ts-expect-error' directive.

2 // @ts-expect-error no typedefs
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The same commands succeed in production mode, so hopefully we can fix the inconsistency somehow.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe this should be lit-vite and generate lit stories?

Do you mean the CLI template should be lit stories? I have no idea, I'm not the right person to ask this!

@shilman shilman force-pushed the shilman/add-web-components-vite-framework-and-template branch from 3c682db to e03ecbe Compare October 2, 2022 13:02
@shilman shilman force-pushed the shilman/add-web-components-vite-framework-and-template branch from 2eca846 to af33595 Compare October 3, 2022 18:56
@socket-security
Copy link

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
es5-ext@0.10.62 (added) postinstall code/yarn.lock via @compodoc/compodoc@1.1.19, pdfmake@0.2.6, @foliojs-fork/linebreak@1.1.1, brfs@2.0.2, static-module@3.0.4, scope-analyzer@2.1.2, es6-map@0.1.5,code/examples/angular-cli/package.json via @compodoc/compodoc@1.1.19, pdfmake@0.2.6, @foliojs-fork/linebreak@1.1.1, brfs@2.0.2, static-module@3.0.4, scope-analyzer@2.1.2, es6-map@0.1.5,scripts/package.json via @compodoc/compodoc@1.1.19, pdfmake@0.2.6, @foliojs-fork/linebreak@1.1.1, brfs@2.0.2, static-module@3.0.4, scope-analyzer@2.1.2, es6-map@0.1.5
🧌 Troll package added

This package is a joke. You should not use it in production.

Package Note Location
es5-ext@0.10.62 (added) This package prints a protestware console message on install regarding Ukraine for users with Russian language locale code/yarn.lock via @compodoc/compodoc@1.1.19, pdfmake@0.2.6, @foliojs-fork/linebreak@1.1.1, brfs@2.0.2, static-module@3.0.4, scope-analyzer@2.1.2, es6-map@0.1.5,code/examples/angular-cli/package.json via @compodoc/compodoc@1.1.19, pdfmake@0.2.6, @foliojs-fork/linebreak@1.1.1, brfs@2.0.2, static-module@3.0.4, scope-analyzer@2.1.2, es6-map@0.1.5,scripts/package.json via @compodoc/compodoc@1.1.19, pdfmake@0.2.6, @foliojs-fork/linebreak@1.1.1, brfs@2.0.2, static-module@3.0.4, scope-analyzer@2.1.2, es6-map@0.1.5
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ⚠️ 1 new troll package detected
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore es5-ext@0.10.62

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@shilman shilman merged commit 51784f6 into next Oct 10, 2022
@shilman shilman deleted the shilman/add-web-components-vite-framework-and-template branch October 10, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants