Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new version-update check telemetry event #20074

Merged
merged 2 commits into from Dec 3, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Dec 3, 2022

Issue: N/A

What I did

Fire a telemetry event whenever version-update successfully runs. This makes it possible for us to tell if the version update logic is working correctly.

How to test

rm -rf node_modules/.cache/storybook

STORYBOOK_TELEMETRY_DEBUG=1 yst
# check for 'version-update' event

STORYBOOK_TELEMETRY_DEBUG=1 yst
# check for no 'version-update' event

If we had a smoke test we could also check that it gets emitted there; this will come later.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman added maintenance User-facing maintenance tasks and removed feature request labels Dec 3, 2022
@shilman shilman merged commit ee0d2a1 into next Dec 3, 2022
@shilman shilman deleted the tom/sb-979-add-telemetry-to-version-update-check branch December 3, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants