Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Polish styling for 7.0 #21255

Merged
merged 7 commits into from Mar 6, 2023
Merged

Addon-docs: Polish styling for 7.0 #21255

merged 7 commits into from Mar 6, 2023

Conversation

MichaelArestad
Copy link
Contributor

@MichaelArestad MichaelArestad commented Feb 24, 2023

What I did

Adds a bit of polish and fixes the ArgsTable rendering in Safari. Huge props to @estelle for helping me out with this.

  • Fixed ArgsTable rendering in Safari
  • Updated vertical rhythm
  • Updated headings
  • Updated link icon

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

code/ui/blocks/src/blocks/mdx.tsx Outdated Show resolved Hide resolved
},
},
// End finicky table styling
// End awesome table styling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪✨

@shilman shilman changed the title Polish docs for 7.0 Addon-docs: Polish styling for 7.0 Mar 6, 2023
@shilman shilman merged commit b3ce386 into next Mar 6, 2023
18 checks passed
@shilman shilman deleted the polish-docs-for-7.0 branch March 6, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants