Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knobs/replace datepicker #4380

Merged
merged 6 commits into from Oct 13, 2018
Merged

Knobs/replace datepicker #4380

merged 6 commits into from Oct 13, 2018

Conversation

ndelangen
Copy link
Member

Also see: #4244

This does the same on master

@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #4380 into master will decrease coverage by 0.18%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4380      +/-   ##
==========================================
- Coverage    36.2%   36.02%   -0.19%     
==========================================
  Files         556      555       -1     
  Lines        6560     6604      +44     
  Branches      848      858      +10     
==========================================
+ Hits         2375     2379       +4     
- Misses       3754     3786      +32     
- Partials      431      439       +8
Impacted Files Coverage Δ
addons/knobs/src/components/types/Date.js 14.28% <14.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f6a29...db05223. Read the comment docs.

@ndelangen
Copy link
Member Author

Merge when ready, thanks for the review @wuweiweiwu and @pksunkara 🙇

@ndelangen ndelangen merged commit 5102f47 into master Oct 13, 2018
@ndelangen ndelangen deleted the knobs/replace-datepicker branch October 13, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants