Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete "Protagonist" operator from OperatorsList.xml file #20

Closed
billmaya opened this Issue Nov 19, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@billmaya
Copy link
Contributor

billmaya commented Nov 19, 2018

This is on line 3502. Since you can't select any actor as the protagonist, i.e. the first actor is always the protagonist, it could result in scripts being created that don't work.

Update 11/19/18: This operator should not be deleted at this time until someone goes through all the existing sample storyworlds and replaces the Protagonist references with the correct actor. Otherwise, when you try to load an old storyworld that uses Protagonist and the Protagonist operator has been removed from the OperatorsList.xml file, you will get the following error message—"I found an unknown operator Protagonist when reading the script."

@billmaya billmaya changed the title Delete "Protagonist" operator from OperatorsList.xml file (line 3502) Delete "Protagonist" operator from OperatorsList.xml file Nov 19, 2018

@jawit-kien

This comment has been minimized.

Copy link

jawit-kien commented Nov 19, 2018

Thanks for helping me understand the code better. Based on your comments, the following questions come to mind:
Would it work if the Protagonist is the first actor ? And what is the difference between the Protagonist operator and the Protagonist actor ?

Also, I'm having trouble finding the OperatorsList.xml file in the repository. Where is it?

@billmaya billmaya added wontfix and removed wontfix labels Nov 20, 2018

@billmaya billmaya added this to the v1.2 milestone Dec 2, 2018

@billmaya billmaya added the enhancement label Dec 2, 2018

@billmaya billmaya added bug and removed enhancement labels Feb 1, 2019

@billmaya billmaya self-assigned this Feb 1, 2019

@billmaya billmaya closed this in d0e016b Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.