Fix input addons #76

Merged
merged 2 commits into from Mar 18, 2013

Conversation

Projects
None yet
3 participants
Contributor

hron84 commented Mar 18, 2013

Quickfix for input markup for addons (it should be improved)

@stouset stouset added a commit that referenced this pull request Mar 18, 2013

@stouset stouset Merge pull request #76 from hron84/fix-input-addons
Fix input addons
4ae2f41

@stouset stouset merged commit 4ae2f41 into stouset:master Mar 18, 2013

Hey! I wonder why this was changed... In the readme it says

/ generates a password field with a descriptive aside
= user.password_field :password do
  %span.help-block
    Must be no larger than 6 characters<br/>
    Must contain only the letters 'x' or 'p'

but with this change i would have to add :add_on => :append to make this work. Is this intended?

Owner

hron84 replied Oct 23, 2013

IIRC I have to do it because the lib did not generated a correct markup for latest Bootstrap and the inputs were completelly broken. As I remember, I just simply copied a code from somewhere another place in this gem, so that requirement should be a side effect. See stouset/twitter_bootstrap_form_for#74 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment