New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 support #7

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@dave-irvine
Copy link

dave-irvine commented Aug 22, 2012

IE8 wasn't ever firing the load event. I think the event was firing before the handler was assigned.

In IE8 it is necessary to set the load handler before setting the src…
… attribute,

as the load handler will fire as soon as the attribute is set, i.e, without it set,
the handler won't fire.
@philipnewcomer

This comment has been minimized.

Copy link

philipnewcomer commented Aug 29, 2012

The demo (http://www.mattstow.com/experiment/responsive-image-maps/rwd-image-maps.html) doesn't work properly in IE8, it'd be nice if this commit was accepted. Not trying to be pushy, but looks like the work has already been done and it just needs to be merged in.

@stowball

This comment has been minimized.

Copy link
Owner

stowball commented Aug 29, 2012

Sorry, but I'm dealing with a family emergency & have limited computer
access so can't test/merge any code for a while
On Aug 29, 2012 5:32 PM, "Philip Newcomer" notifications@github.com wrote:

The demo (
http://www.mattstow.com/experiment/responsive-image-maps/rwd-image-maps.html)
doesn't work properly in IE8, it'd be nice if this commit was accepted. Not
trying to be pushy, but looks like the work has already been done and it
just needs to be merged in.


Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-8131456.

@philipnewcomer

This comment has been minimized.

Copy link

philipnewcomer commented Aug 29, 2012

I see. Sorry to bother you, hope it's not serious.

@discotizer

This comment has been minimized.

Copy link

discotizer commented Sep 12, 2012

IE 8 support would be great. As i dont have a real IE8 to test i used the Developer tools in IE9 (F12) to simulate IE8. With the original script, the old coordinates were shown, now no links are shown but as there is a change in behaviour i think it's just the simulated IE8 mode that doesn't show the resized map.

@bmartinstudio

This comment has been minimized.

Copy link

bmartinstudio commented Sep 23, 2012

I second the IE8 support when you have a chance. However, I am also testing using the developer tools in IE9 and would be interested to know if it actually does work on a real, live version of IE8.

Best of luck with your family and I hope all is well.

@stowball

This comment has been minimized.

Copy link
Owner

stowball commented Oct 6, 2012

Merged and tested in real IE8 & IE9 compatibility mode and it now works as expected. Thanks @dave-irvine. Also fixed it to maintain chainability and made other optimisations. Here's the commit: 369c574

@dave-irvine dave-irvine closed this Oct 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment