New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Automatic-Module-Name entry #52

Merged
merged 1 commit into from May 5, 2018

Conversation

Projects
None yet
2 participants
@io7m
Copy link
Contributor

io7m commented Feb 9, 2018

This adds an Automatic-Module-Name entry to the jar to give a stable
name that can be used in a "requires" clause in a JPMS module. The
name used is "net.i2p.crypto.eddsa" to match the symbolic name used
in the OSGi metadata.

Add an Automatic-Module-Name entry
This adds an Automatic-Module-Name entry to the jar to give a stable
name that can be used in a "requires" clause in a JPMS module. The
name used is "net.i2p.crypto.eddsa" to match the symbolic name used
in the OSGi metadata.
@io7m

This comment has been minimized.

Copy link
Contributor

io7m commented Feb 9, 2018

The reasons for doing this are discussed in Stephen Colebourne's blog.

The project looks to be in good shape with regards to future full modularization: You know which packages you export (due to your up-to-date OSGi metadata) and you don't have any dependencies. Should be easy work to add a real module descriptor later.

@str4d

This comment has been minimized.

Copy link
Owner

str4d commented May 4, 2018

Thanks for the PR! I'll review it this weekend.

@str4d

str4d approved these changes May 5, 2018

Copy link
Owner

str4d left a comment

Thanks for this!

@str4d str4d merged commit 1b6e8c3 into str4d:master May 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@str4d str4d added this to the 0.2.1 milestone May 5, 2018

@io7m

This comment has been minimized.

Copy link
Contributor

io7m commented May 5, 2018

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment