From d25ee1dd60f316e9b7b8e4dcc28a6ee60ab2f7a7 Mon Sep 17 00:00:00 2001 From: Andrew Gouin Date: Sat, 24 Jun 2023 10:35:04 -0600 Subject: [PATCH 1/2] ignore lint error for signal.Notify --- builder/builder.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/builder.go b/builder/builder.go index 0caaed2..b8f3f53 100644 --- a/builder/builder.go +++ b/builder/builder.go @@ -464,7 +464,7 @@ func (h *HeighlinerBuilder) queueTmpDirRemoval(tmpDir string, start bool) { // registerSigIntHandler will delete tmp dirs on ctrl+c func (h *HeighlinerBuilder) registerSigIntHandler() { c := make(chan os.Signal) - //nolint:govet + //nolint:govet,staticcheck signal.Notify(c, os.Interrupt, syscall.SIGTERM) go func() { <-c From 76ff6ec81cf29b3ba032a0c4e2e74935af8fce45 Mon Sep 17 00:00:00 2001 From: Andrew Gouin Date: Mon, 26 Jun 2023 11:10:18 -0600 Subject: [PATCH 2/2] actually fix --- builder/builder.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/builder/builder.go b/builder/builder.go index b8f3f53..5551971 100644 --- a/builder/builder.go +++ b/builder/builder.go @@ -463,8 +463,7 @@ func (h *HeighlinerBuilder) queueTmpDirRemoval(tmpDir string, start bool) { // registerSigIntHandler will delete tmp dirs on ctrl+c func (h *HeighlinerBuilder) registerSigIntHandler() { - c := make(chan os.Signal) - //nolint:govet,staticcheck + c := make(chan os.Signal, 1) signal.Notify(c, os.Interrupt, syscall.SIGTERM) go func() { <-c