Skip to content

Conversation

@megvalcour
Copy link

What does it do?

Adds line break to indicate that NODE_ENV=production and npm run build are separate commands.

Why is it needed?

Without the line break, developers unfamiliar with npm might be confused and think it's a single command.

Related issue(s)/PR(s)

Merging with main per @derrickmehaffy in #107

@derrickmehaffy
Copy link
Member

@megvalcour Actually in this case it is one command :) it's better to scope commands like this so that you don't accidentally pass a var to another application. Setting it without suffix command will set it as the session level.

The current syntax is intended, going to close this one but thank you!

@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/new-documentation-release-v4-5-5/24573/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants