Improve cors documentation#2444
Merged
Merged
Conversation
We can pass a function to the `origin` property to have better handling of the cors configuration
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pwizla
approved these changes
Mar 31, 2025
pwizla
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @oktapodia!
The PR is now approved, merged, should be live on docs.strapi.io in a few minutes, and will be mentioned in the next weekly snapshot release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Improve documentation
Describe the technical changes you did.
We can pass a function to the
originproperty to have better handling of the cors configurationWhy is it needed?
cors plugin is quite limited without that, especially when you need to have some partial wildcard URLs, e.g.
https://test-git-*.vercel.appDescribe the issue you are solving.
Documenting how to pass function to origin + its signature
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request