Expand and improve Client docs - #2602
Conversation
Clearer examples and addition of error message if baseURL is missing protocol
Added note that this is the only auth method currently; added error message
Standardising with rest of docs
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
innerdvations
left a comment
There was a problem hiding this comment.
Is this your first Strapi PR?! 🎉
I gave it a quick look but haven't tested the code examples yet
ac6cd23 to
edd788d
Compare
This reverts commit edd788d.
|
Hey @hanpaine! Congrats on your very first docs PR! It's already great 🫶 However, upon further inspection 👀 , it seems I need to do a deeper rewrite. Because what's new is actually adding the So I will largely reorganize the content, for consistency and clarity. Thank you very much again for your base work, it's really helpful! 👏 |
so that the new upload-related information better fits with the existing information architecture
|
@hanpaine I finished rewriting the PR content so it better fits with the existing information architecture. (The only thing that's bugging me is that it's using "ids" in code examples. I thought we switched to |
Co-authored-by: Jamie Howard <48524071+jhoward1994@users.noreply.github.com>
Co-authored-by: Jamie Howard <48524071+jhoward1994@users.noreply.github.com>
U&P is usable now (but still not documented here)
👋 Thanks for contributing to Strapi's documentation!I've reviewed the changes in your file, and here's what I found: 🎉 Excellent work! Your documentation perfectly follows all our writing guidelines. What this means: Your contribution is ready to help developers worldwide! 🌍 📚 Helpful Resources: 🤖 This review focuses only on the lines you've changed. Questions? Feel free to ask in the comments! 🔧 Manually triggered validation for PR #2602 |
What does it do?
** note this documentation was created with the help of Dosu :)
Why is it needed?
Documentation for media upload is currently missing from Strapi docs.
Related issue(s)/PR(s)
strapi/client#92