Skip to content

Add warning about DigitalOcean MDB + App Platform #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

derrickmehaffy
Copy link
Member

What does it do?

Adds a warning about the security issue with DigitalOcean Managed Databases + the DO App platform and not being able to add the app as a trusted source

Why is it needed?

Properly informing our community of a potential security issue with a deployment from our documentation

Related issue(s)/PR(s)

External Forum Thread: https://www.digitalocean.com/community/questions/how-to-add-my-digitalocean-app-as-a-trusted-resource-for-my-managed-database

External Feature Request: https://ideas.digitalocean.com/ideas/APPX-I-73

@derrickmehaffy derrickmehaffy added severity: high If it breaks the basic use of the product internal PRs created by the Strapi core team labels Jun 18, 2021
@derrickmehaffy derrickmehaffy requested a review from pwizla June 18, 2021 20:03
@derrickmehaffy derrickmehaffy self-assigned this Jun 18, 2021
@vercel
Copy link

vercel bot commented Jun 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/strapijs/documentation/CZjeQrGmqLDJpwdLf3D7dvu9UHCE
✅ Preview: https://documentation-git-deployment-doappswarning-strapijs.vercel.app

@derrickmehaffy derrickmehaffy added the flag: don't merge This PR should not be merged at the moment label Jun 18, 2021
@derrickmehaffy
Copy link
Member Author

@pwizla This PR should be delayed from merging for at least 7 days from now as I've struck up a conversation with DigitalOcean about this and am informing them of our intention to add this security warning.

I'll let you know once we are good to merge. (After you review of course)

@derrickmehaffy
Copy link
Member Author

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/digitalocean-app-platform-is-unable-to-secure-managed-database-now-what/5755/5

@derrickmehaffy
Copy link
Member Author

@pwizla I assume I'll need to refactor this for the changes to the guides yeah?

@pwizla
Copy link
Collaborator

pwizla commented Jun 22, 2021

@pwizla I assume I'll need to refactor this for the changes to the guides yeah?

I don't think so. This is just a callout in a deployment guide, and we are going to deploy reworked installation guides. 🙂

@derrickmehaffy
Copy link
Member Author

@pwizla as I have not had any clarifying information from DigitalOcean on this, this is now good to be merged after your review.

@derrickmehaffy derrickmehaffy removed the flag: don't merge This PR should not be merged at the moment label Jun 24, 2021
@pwizla pwizla merged commit 6b52f99 into main Jul 2, 2021
@pwizla pwizla deleted the deployment/DOAppsWarning branch July 2, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs created by the Strapi core team pr: security notice severity: high If it breaks the basic use of the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants