Skip to content

Update Email and Upload provider docs / copy readmes from monorepo #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 3, 2021
Merged

Update Email and Upload provider docs / copy readmes from monorepo #536

merged 6 commits into from
Dec 3, 2021

Conversation

@derrickmehaffy
Copy link
Member

@derrickmehaffy derrickmehaffy commented Dec 1, 2021 •
edited
Loading

Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com

This PRs copies in the READMEs from each provider (to be automated in the future) and updates both the email and upload docs for v4

Edit: Removed copied readmes based on feedback, instead linked to the npm packages

@derrickmehaffy
init email provider readme's from mono and update doc
a3db102 
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@derrickmehaffy derrickmehaffy added size: medium If the PR includes 1+ file(s) with a total of 10 to 50 lines of text or <100 lines of code source: Dev Docs PRs/issues targeting the Developer Docs target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch). pr: fix Used on the docs repo for anything that is not "new" or "updated" content: chore, typos, fixes, etc. labels Dec 1, 2021
@vercel
Copy link

vercel bot commented Dec 1, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

documentation – ./docs

🔍 Inspect: https://vercel.com/strapijs/documentation/BQqYJ7dN2R6oXfPAaB2TW7WWCW4i
✅ Preview: https://documentation-git-fixes-providers-strapijs.vercel.app

@derrickmehaffy
Remove copy of READMEs and change links to npm
8c95573 
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@derrickmehaffy derrickmehaffy requested a review from pwizla December 1, 2021 16:30
@derrickmehaffy derrickmehaffy marked this pull request as ready for review December 1, 2021 16:30
@derrickmehaffy derrickmehaffy linked an issue Dec 2, 2021 that may be closed by this pull request
[Request]: Upload plugin page should be updated for v4 #533
Closed
pwizla
pwizla reviewed Dec 3, 2021
View reviewed changes
pwizla
pwizla reviewed Dec 3, 2021
View reviewed changes
pwizla
pwizla previously approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor the small comments I made. Thank you Derrick!

@derrickmehaffy
Copy link
Member Author

derrickmehaffy commented Dec 3, 2021

LGTM minor the small comments I made. Thank you Derrick!

fixing them now

@derrickmehaffy @pwizla
Update docs/developer-docs/latest/plugins/email.md
2bd7627 
Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com>
@pwizla pwizla self-requested a review December 3, 2021 16:00
pwizla
pwizla approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derrickmehaffy derrickmehaffy merged commit e40b1a1 into main Dec 3, 2021
@derrickmehaffy derrickmehaffy deleted the fixes/providers branch December 3, 2021 16:01
@derrickmehaffy derrickmehaffy mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pwizla pwizla pwizla approved these changes

Assignees

No one assigned

Labels

pr: fix Used on the docs repo for anything that is not "new" or "updated" content: chore, typos, fixes, etc. size: medium If the PR includes 1+ file(s) with a total of 10 to 50 lines of text or <100 lines of code source: Dev Docs PRs/issues targeting the Developer Docs target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Request]: Upload plugin page should be updated for v4

2 participants

@derrickmehaffy @pwizla