Skip to content

Conversation

@bogdaaamn
Copy link
Contributor

What does it do?

I have walked through the Hosting Proivder Guides > Heroku and install Strapi v4 on a Heroku instance. With some changes in the database.js, I confirm it works well on the v4.

Why is it needed?

I fixed the following issues:

Related issue(s)/PR(s)

n/a

@strapi-cla
Copy link

strapi-cla commented Dec 2, 2021

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Dec 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

documentation – ./docs

🔍 Inspect: https://vercel.com/strapijs/documentation/HWxjTqXRyipd6iYLmWA6Q3u2yJUR
✅ Preview: https://documentation-git-fork-bogdaaamn-docs-heroku-de-bc65b5-strapijs.vercel.app

@pwizla pwizla self-assigned this Dec 3, 2021
@pwizla pwizla added size: medium If the PR includes 1+ file(s) with a total of 10 to 50 lines of text or <100 lines of code source: Dev Docs PRs/issues targeting the Developer Docs target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch). pr: updated content PRs updating existing documentation content labels Dec 3, 2021
@pwizla
Copy link
Collaborator

pwizla commented Dec 3, 2021

Thank you very much @bogdaaamn ! I will review it today :-)

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂 Thank you again for your very first contribution to Strapi docs, @bogdaaamn, we really appreciate it 🤗
It's merged and will be live with the next deployment batch.

@pwizla pwizla merged commit b9dbe09 into strapi:main Dec 3, 2021
@bogdaaamn
Copy link
Contributor Author

Thanks a lot @pwizla!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: updated content PRs updating existing documentation content size: medium If the PR includes 1+ file(s) with a total of 10 to 50 lines of text or <100 lines of code source: Dev Docs PRs/issues targeting the Developer Docs target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants