Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@Mcastres
Copy link
Contributor

@Mcastres Mcastres commented Jul 5, 2021

This PR is about improving FoodAdvisor.

@fdel-car
Copy link

fdel-car commented Jul 9, 2021

Hello, just listing some issues that I encountered during my test of the project itself:

  • Our old version of sqlite3 has issues if only python3 is installed, which is the case for recent distributions. This could be bothering our users or even stop them completely in their tracks.
  • The seed.js script in the api folder, is replacing everything inside of the .env file. Could be an issue as well when people follow the README in order.
  • In the client folder, .env.example should be renamed to .env or .env.development.

Note: .env, .env.development, and .env.production files should be included in your repository as they define defaults. .env*.local should be added to .gitignore, as those files are intended to be ignored. .env.local is where secrets can be stored.

The above was taken from the Next.js doc, it would simplify the README since the user won't have to create his own .env file if the default settings suit him.

  • The Swagger plugin does not seem to be installed by default even though the guided tour says so.

I'll update this list if I'm mistaken or if I find others and I'll start reviewing the PR itself soon I promise xD

@Mcastres
Copy link
Contributor Author

Thanks for your comments Fabien! Everything has been fixed 👍

@alexandrebodin alexandrebodin merged commit 51defe0 into master Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants