From 8592bde151bcca3c32db1f64d256096539517db5 Mon Sep 17 00:00:00 2001
From: Jamie Howard <48524071+jhoward1994@users.noreply.github.com>
Date: Thu, 9 May 2024 14:39:05 +0100
Subject: [PATCH] fix: u&p FE tests (#20289)

* fix: use act in u&p test

* fix: clean up
---
 .../pages/Roles/pages/tests/EditPage.test.jsx | 21 +++----------------
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/packages/plugins/users-permissions/admin/src/pages/Roles/pages/tests/EditPage.test.jsx b/packages/plugins/users-permissions/admin/src/pages/Roles/pages/tests/EditPage.test.jsx
index 7d90e895386..f8813d4d693 100644
--- a/packages/plugins/users-permissions/admin/src/pages/Roles/pages/tests/EditPage.test.jsx
+++ b/packages/plugins/users-permissions/admin/src/pages/Roles/pages/tests/EditPage.test.jsx
@@ -96,13 +96,15 @@ describe('Roles – EditPage', () => {
     expect(getByRole('textbox', { name: 'Description' })).toHaveAttribute('aria-invalid', 'true');
   });
 
-  it("can update a role's name and description", async () => {
+  it("can update a role's name, description and permissions", async () => {
     const { getByRole, user, getByText, findByRole, findByText } = render();
 
     await waitForElementToBeRemoved(() => getByText('Loading content.'));
 
     await user.type(getByRole('textbox', { name: 'Name' }), 'test');
     await user.type(getByRole('textbox', { name: 'Description' }), 'testing');
+    await user.click(getByRole('button', { name: 'Address' }));
+    await user.click(getByRole('checkbox', { name: 'create' }));
 
     const button = await findByRole('button', { name: 'Save' });
     /**
@@ -111,23 +113,6 @@ describe('Roles – EditPage', () => {
     fireEvent.click(button);
     await findByText('Role edited');
     await findByText('Authenticated');
-  });
-
-  it("can update a role's permissions", async () => {
-    const { getByRole, user, getByText } = render();
-
-    await waitForElementToBeRemoved(() => getByText('Loading content.'));
-
-    await user.click(getByRole('button', { name: 'Address' }));
-
-    await user.click(getByRole('checkbox', { name: 'create' }));
-
-    /**
-     * @note user.click will not trigger the form.
-     */
-    fireEvent.click(getByRole('button', { name: 'Save' }));
-
-    await waitFor(() => expect(getByText('Role edited')).toBeInTheDocument());
 
     /**
      * @note the permissions are refetched, because we're mocking calls no real update will be made.